[PATCH] D24410: Use call target count to derive the call instruction weight

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 18 13:45:20 PDT 2016


dnovillo added a comment.

OK, so instead of looking at the number of samples collected at the call site, it looks at the number of calls the target had.  But what if the target is called disproportionately more from one call site than the other?

Like:

if (this_is_true_95_percent_of_the_time())

  A();

else

  A();

The example is ridiculous, I know, but wouldn't we end up inlining A() in both branches of the if()?  Is that a code growth issue in general?


https://reviews.llvm.org/D24410





More information about the llvm-commits mailing list