[PATCH] D24691: AMDGPU: Use unsigned compare for eq/ne

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 17:04:41 PDT 2016


arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng, kzhuravl, arsenm, qcolombet, MatzeB.

For some reason there are both of these available, except
for scalar 64-bit compares which only has u64. I'm not sure
why there are both (I'm guessing it's for the one bit inputs we
don't use), but for consistency always using the
unsigned one.


https://reviews.llvm.org/D24691

Files:
  lib/Target/AMDGPU/SIInstrInfo.cpp
  lib/Target/AMDGPU/SIInstructions.td
  lib/Target/AMDGPU/SILowerI1Copies.cpp
  lib/Target/AMDGPU/SIShrinkInstructions.cpp
  lib/Target/AMDGPU/SOPInstructions.td
  test/CodeGen/AMDGPU/32-bit-local-address-space.ll
  test/CodeGen/AMDGPU/addrspacecast.ll
  test/CodeGen/AMDGPU/basic-branch.ll
  test/CodeGen/AMDGPU/branch-uniformity.ll
  test/CodeGen/AMDGPU/cf-loop-on-constant.ll
  test/CodeGen/AMDGPU/cndmask-no-def-vcc.ll
  test/CodeGen/AMDGPU/commute-compares.ll
  test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
  test/CodeGen/AMDGPU/convergent-inlineasm.ll
  test/CodeGen/AMDGPU/ctlz.ll
  test/CodeGen/AMDGPU/ctlz_zero_undef.ll
  test/CodeGen/AMDGPU/fdiv.f64.ll
  test/CodeGen/AMDGPU/i1-copy-phi.ll
  test/CodeGen/AMDGPU/icmp64.ll
  test/CodeGen/AMDGPU/indirect-addressing-si.ll
  test/CodeGen/AMDGPU/inline-asm.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.div.fmas.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.icmp.ll
  test/CodeGen/AMDGPU/llvm.round.f64.ll
  test/CodeGen/AMDGPU/select-i1.ll
  test/CodeGen/AMDGPU/select-vectors.ll
  test/CodeGen/AMDGPU/selectcc-opt.ll
  test/CodeGen/AMDGPU/selectcc.ll
  test/CodeGen/AMDGPU/setcc-opt.ll
  test/CodeGen/AMDGPU/setcc.ll
  test/CodeGen/AMDGPU/setcc64.ll
  test/CodeGen/AMDGPU/sgpr-control-flow.ll
  test/CodeGen/AMDGPU/si-annotate-cf.ll
  test/CodeGen/AMDGPU/si-lower-control-flow-unreachable-block.ll
  test/CodeGen/AMDGPU/sint_to_fp.f64.ll
  test/CodeGen/AMDGPU/sint_to_fp.i64.ll
  test/CodeGen/AMDGPU/sint_to_fp.ll
  test/CodeGen/AMDGPU/skip-if-dead.ll
  test/CodeGen/AMDGPU/sopk-compares.ll
  test/CodeGen/AMDGPU/spill-m0.ll
  test/CodeGen/AMDGPU/subreg-coalescer-undef-use.ll
  test/CodeGen/AMDGPU/trunc-cmp-constant.ll
  test/CodeGen/AMDGPU/trunc.ll
  test/CodeGen/AMDGPU/uint_to_fp.f64.ll
  test/CodeGen/AMDGPU/uint_to_fp.i64.ll
  test/CodeGen/AMDGPU/uint_to_fp.ll
  test/CodeGen/AMDGPU/uniform-cfg.ll
  test/CodeGen/AMDGPU/uniform-loop-inside-nonuniform.ll
  test/CodeGen/AMDGPU/valu-i1.ll
  test/CodeGen/AMDGPU/zero_extend.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24691.71715.patch
Type: text/x-patch
Size: 55462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160917/bac4e6c6/attachment-0001.bin>


More information about the llvm-commits mailing list