[PATCH] D24680: Jump threading: avoid trying to split edge into landingpad block (PR27840)

Nick Lewycky via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 16:22:27 PDT 2016


nlewycky added a comment.

I'm concerned that the fix is too narrow. There's 10 callers to llvm::SplitEdge in LLVM and haven't audited them so I don't know whether they also check whether they also do this check. It's certainly not in the comment on SplitEdge that it's allowed to assert if you pass it a landing pad block.


https://reviews.llvm.org/D24680





More information about the llvm-commits mailing list