[PATCH] D24650: [ELF] - Linkerscript: PR30387 - cannot handle EXCLUDE_FILE in the middle of a input section description.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: lld/trunk/ELF/LinkerScript.cpp:992
@@ +991,3 @@
+// Example: *(.foo.1 EXCLUDE_FILE (*a.o) .foo.2 EXCLUDE_FILE (*b.o) .foo.3)
+void ScriptParser::readSectionExcludes(InputSectionDescription *Cmd) {
+  llvm::Regex ExcludeFileRe;
----------------
It's not clear to me what the grammar of this thing is.

  A B EXCLUDE_FILE(C) D E

Does the above pattern mean A, B, D except those matching C, and E? Or A, B, D except those matching C, E except those matching C?

What if the pattern is this?

  A B EXCLUDE_FILE(C) EXCLUDE_FILE(D) E



Repository:
  rL LLVM

https://reviews.llvm.org/D24650