[PATCH] D24616: [ELF] Improve section GC for comdat groups

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 05:28:15 PDT 2016


On 15 September 2016 at 13:43, Eugene Leviant <evgeny.leviant at gmail.com>
wrote:

> evgeny777 created this revision.
> evgeny777 added reviewers: ruiu, rafael.
> evgeny777 added subscribers: grimar, llvm-commits.
> evgeny777 set the repository for this revision to rL LLVM.
> evgeny777 added a project: lld.
>
> This patch fixes two things
>
> 1) If any section within comdat group is marked Live an entire group is
> marked live.
>



I don't think we should do this. That is not what gold does and I think it
is an important feature to be able to gc part of a comdat.

The abi implemented by gcc/clang will put multiple destructors in the same
comdat (D0/D1/D2) and the linker should be able to remove unused ones.

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160916/8f791aab/attachment.html>


More information about the llvm-commits mailing list