[PATCH] D24657: [compiler-rt] Disable building of profiling runtime when LLVM_USE_SANITIZER is set

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 04:19:10 PDT 2016


kubabrecka created this revision.
kubabrecka added reviewers: davidxl, vsk, compnerd.
kubabrecka added subscribers: llvm-commits, zaks.anna.
Herald added subscribers: mgorny, beanz, dberris.

Currently, when doing a ASanified build of LLVM (with Clang, compiler-rt and libcxx) via `-DLLVM_USE_SANITIZER=Address` and not using any other options, we already disable building of sanitizer runtimes (because they themselves can’t be sanitized) and also exclude the sanitizer tests.  However, the same is not done for the profiling runtime, which will build fine, but then all the tests fail due to linking errors.  Let’s disable the profiling runtime as well (when LLVM_USE_SANITIZER is set).

This is currently failing on the Darwin ASan+UBSan bot: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2425/console


https://reviews.llvm.org/D24657

Files:
  cmake/config-ix.cmake

Index: cmake/config-ix.cmake
===================================================================
--- cmake/config-ix.cmake
+++ cmake/config-ix.cmake
@@ -462,7 +462,7 @@
   set(COMPILER_RT_HAS_MSAN FALSE)
 endif()
 
-if (PROFILE_SUPPORTED_ARCH AND
+if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
     OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows")
   set(COMPILER_RT_HAS_PROFILE TRUE)
 else()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24657.71613.patch
Type: text/x-patch
Size: 404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160916/6777b128/attachment.bin>


More information about the llvm-commits mailing list