[PATCH] D24622: LTO: Simplify caching interface.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 16:45:30 PDT 2016


pcc added inline comments.

================
Comment at: tools/llvm-lto2/llvm-lto2.cpp:203-204
@@ -217,1 +202,4 @@
+                         EC.message() + "\n");
+
+    *AddStream(Task)->OS << (*ReloadedBufferOrErr)->getBuffer();
   };
----------------
mehdi_amini wrote:
> As a side note: this is really inefficient: this is duplicating the file through memory without any apparent reason?
This is what the original code was doing.

(I'd like this code to provide some way for test cases to match filenames rather than blindly copying the contents across, but that can be done separately.)


https://reviews.llvm.org/D24622





More information about the llvm-commits mailing list