[PATCH] D24622: LTO: Simplify caching interface.

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

> make it harder to replace the cache implementation in an arbitrary client.


The class CacheObjectOutput is just a possible implementation in-tree for convenience, but just subclassing the NativeObjectOutput for any other custom cache implementation is quite simple.  This is not clear to me what you mean then.


================
Comment at: include/llvm/LTO/LTO.h:309
@@ -309,1 +308,3 @@
+  /// AddFile functions to add native object files to the link.
+  Error run(AddStreamFn AddStream, AddFileFn AddFile);
 
----------------
mehdi_amini wrote:
> I'm not in favor of this, currently a client that don't need caching does not need to handle file input.
> I'm not in favor of this, currently a client that don't need caching does not need to handle file input....

... currently. 



https://reviews.llvm.org/D24622