[PATCH] D24611: [ELF] - Linkerscript: implemented SORT_BY_INIT_PRIORITY.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 10:45:41 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/LinkerScript.cpp:113
@@ -112,1 +112,3 @@
 
+static bool compareInit(InputSectionData *A, InputSectionData *B) {
+  return getPriority(A->Name) < getPriority(B->Name);
----------------
comparePriority

================
Comment at: ELF/LinkerScript.cpp:977
@@ -970,1 +976,3 @@
+  if (skip("SORT_BY_INIT_PRIORITY"))
+    return SortByInit;
   return SortNone;
----------------
SortByPriority

================
Comment at: test/ELF/linkerscript/sort-init.s:25
@@ +24,2 @@
+  .byte 5
+
----------------
Remove trailing blank line.


https://reviews.llvm.org/D24611





More information about the llvm-commits mailing list