[PATCH] D24595: [lib/LTO] Remove now unneded hack for undefined symbols

[Mehdi Amini via llvm-commits]

> On Sep 15, 2016, at 9:35 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> BTW, that doesn't seem to be the only issue.
> 
> Right now patatino gets internalized, which fails the verifier, that would be fixed by  pr30396 or some workaround.
> 
> But, adding -upatatino to the command line causes gold to fail because foo is internalized. I can't quite make what is the code path that is missing, but nothing creates the llvm.compiler.used that should prevent foo from being removed.

Indeed, it looks like the call to updateCompilerUsed got lost in the new API…

Teresa: for ThinLTO it got lost when you moved to the index-based internalization in http://reviews.llvm.org/D20290 I believe.


— 
Mehdi



> 
> Cheers,
> Rafael
> 
> 
> 
> 
> On 15 September 2016 at 11:27, Rafael Espíndola <rafael.espindola at gmail.com <mailto:rafael.espindola at gmail.com>> wrote:
> 
> Yes that sounds the proper fix: we should have llvm-nm report the correct list for instance.
> 
> Reported https://llvm.org/bugs/show_bug.cgi?id=30396 <https://llvm.org/bugs/show_bug.cgi?id=30396> to track it.
> 
> Cheers,
> Rafael
>  
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160915/baaa7d10/attachment.html>