[PATCH] D24557: [Loop Vectorizer] Simplified GEP cloning. NFC.

[Adam Nemet via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D24557#543702, @mssimpso wrote:

> Regarding the "uniform" assertion, I had been assuming this is equivalent to Legal->isUniform(), but I took a look at the implementation of isUniform in LAI. Over there, we have something like:
>
>   PSE.getSE()->isLoopInvariant(PSE.getSE()->getSCEV(Value), Loop);
>
>
> Whereas here, we have something like:
>
>   PSE.getSE()->isLoopInvariant(PSE.getSCEV(Value), Loop);
>
>
> I'm not familiar enough with PSE to know what, if any, difference this might make.


Yes, they are different.  The second form can assume the predicates from PSE and produce a SCEV that's more friendly to optimizations.


Repository:
  rL LLVM

https://reviews.llvm.org/D24557