[llvm] r281579 - [llvm-cov] Don't print a verbose title when looking at one file

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 21:41:40 PDT 2016


Author: vedantk
Date: Wed Sep 14 23:41:39 2016
New Revision: 281579

URL: http://llvm.org/viewvc/llvm-project?rev=281579&view=rev
Log:
[llvm-cov] Don't print a verbose title when looking at one file

Having the same title, timestamp, etc. occur repeatedly creates an
unnecessary distraction when paging through a report.

Modified:
    llvm/trunk/test/tools/llvm-cov/Inputs/showProjectSummary.test
    llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp

Modified: llvm/trunk/test/tools/llvm-cov/Inputs/showProjectSummary.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/Inputs/showProjectSummary.test?rev=281579&r1=281578&r2=281579&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cov/Inputs/showProjectSummary.test (original)
+++ llvm/trunk/test/tools/llvm-cov/Inputs/showProjectSummary.test Wed Sep 14 23:41:39 2016
@@ -1,6 +1,6 @@
 TEXT-TITLE: Test Suite
-TEXT: Coverage Report
-TEXT: Created:
+TEXT-NOT: Coverage Report
+TEXT-NOT: Created:
 TEXT-FILE-NOT: (Binary: showProjectSummary.covmapping)
 TEXT-FUNCTION: main:
 TEXT-FOOTER: Generated by llvm-cov

Modified: llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp?rev=281579&r1=281578&r2=281579&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp (original)
+++ llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp Wed Sep 14 23:41:39 2016
@@ -168,7 +168,7 @@ void SourceCoverageView::addInstantiatio
 
 void SourceCoverageView::print(raw_ostream &OS, bool WholeFile,
                                bool ShowSourceName, unsigned ViewDepth) {
-  if (WholeFile)
+  if (WholeFile && getOptions().hasOutputDirectory())
     renderCellInTitle(OS, "Coverage Report");
 
   renderViewHeader(OS);




More information about the llvm-commits mailing list