[PATCH] D24582: [MC] Handle discardable COFF sections in assembly

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 15:41:05 PDT 2016


rnk added a comment.

Thanks!


================
Comment at: lib/MC/MCSectionCOFF.cpp:67
@@ -66,1 +66,3 @@
     OS << 's';
+  if (getCharacteristics() & COFF::IMAGE_SCN_MEM_DISCARDABLE &&
+      !isImplicitlyDiscardable(SectionName))
----------------
majnemer wrote:
> Maybe parens because of the bitwise operator?
Yeah, man, I can never remember the bitwise operator precedence. Parens++


https://reviews.llvm.org/D24582





More information about the llvm-commits mailing list