[PATCH] D24170: Refactor replaceDominatedUsesWith to have a flag to control whether to replace uses in BB itself.

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 14:54:48 PDT 2016


danielcdh added a comment.

In https://reviews.llvm.org/D24170#537323, @danielcdh wrote:

> Updated the callsite in https://reviews.llvm.org/D22778 to invoke the other API with a loop so that the API change is not required.
>
> PTAL


Turns out the other API (dominate by edge) does not work for this purpose. I still need to use the original API (dominate by block). I've added code at the callsite to handle this. It does not look very elegant, but it's the only way I can think of that does not require API change (nor can I think of a better way to change API to make it more reasonable). Let me know if you have any suggestions.


https://reviews.llvm.org/D24170





More information about the llvm-commits mailing list