[PATCH] D24545: [LTO] Fix commons handling

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 14:16:32 PDT 2016


> On Sep 14, 2016, at 2:03 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> 
> pcc accepted this revision.
> pcc added a comment.
> This revision is now accepted and ready to land.
> 
> LGTM
> 
>> Isn't is already what LARGE-PREVAILED and SMALL-PREVAILED are?
> 
> 
> Yes, sorry, I missed those.
> 
> One other thing: the test you are updating should live in test/LTO/Resolution/X86 because it is testing the API rather than the command line tool.

Moved separately in r281539.

— 
Mehdi



More information about the llvm-commits mailing list