[PATCH] D23039: Kill deprecated attribute API

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 14:07:14 PDT 2016


mehdi_amini added inline comments.

================
Comment at: docs/ReleaseNotes.rst:44
@@ -36,1 +43,3 @@
+* The old Bitcode format for attribute is not supported anymore. Attributes
+  in bitcode generated by llvm 3.2 and prior will be ignored.
 
----------------
deadalnix wrote:
> mehdi_amini wrote:
> > deadalnix wrote:
> > > mehdi_amini wrote:
> > > > Could we miscompile such bitcode files? It is not clear what is dropped here.
> > > > 
> > > We are basically ignoring attributes for these. This indeed probably breaks some old bytecode. This was a planned removal, so I think this is fine. However, we may want to have some from form of error triggered rather than just ignoring the old attribute format. I'll do whatever the community think is best here.
> > Sorry but "This indeed probably breaks some old bytecode" followed by "I think this is fine" does not get along together well :)
> > 
> > We are supposed to process correctly bitcode as old as 3.0.
> > 
> This is clearly documented that this is going away in 4.0 . Would generating an error be fine ?
All these comments that refer to 4.0 are stalled: the policy changed when we change the numbering format.



https://reviews.llvm.org/D23039





More information about the llvm-commits mailing list