[PATCH] D24582: [MC] Add section flag 'D' for disardable COFF sections

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 14:01:06 PDT 2016


rnk created this revision.
rnk added reviewers: majnemer, rafael.
rnk added a subscriber: llvm-commits.

This fixes a dumpbin warning on objects produced by the MC assembler
when starting from text. All .debug$S sections are supposed to be marked
IMAGE_SCN_MEM_DISCARDABLE. The main, non-COMDAT .debug$S section had
this set, but any comdat ones were not being marked discardable because
there was no .section flag for it.

Gas does not appear to have an existing code for this flag, so I chose
'D'.

https://reviews.llvm.org/D24582

Files:
  lib/MC/MCParser/COFFAsmParser.cpp
  lib/MC/MCSectionCOFF.cpp
  test/MC/COFF/section.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24582.71427.patch
Type: text/x-patch
Size: 2982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160914/2c7ddade/attachment.bin>


More information about the llvm-commits mailing list