[PATCH] D24545: [LTO] Fix commons handling

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 13:51:42 PDT 2016


pcc added inline comments.

================
Comment at: lib/LTO/LTO.cpp:357
@@ +356,3 @@
+    // We take the maximum Size/Alignment over all the prevailing Common.
+    // The client has to mark all the common as prevailing to take the max of
+    // all.
----------------
Please update this comment.

================
Comment at: test/tools/llvm-lto2/X86/common.ll:57
@@ +56,3 @@
+
+; Client marked both as prevailing
+; RUN: llvm-lto2 %t1.bc %t2.bc -o %t.o -save-temps \
----------------
Please also add a test with a single common marked as prevailing.


https://reviews.llvm.org/D24545





More information about the llvm-commits mailing list