[PATCH] D23039: Kill deprecated attribute API

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 12:21:59 PDT 2016


deadalnix added inline comments.

================
Comment at: docs/ReleaseNotes.rst:44
@@ -36,1 +43,3 @@
+* The old Bitcode format for attribute is not supported anymore. Attributes
+  in bitcode generated by llvm 3.2 and prior will be ignored.
 
----------------
mehdi_amini wrote:
> Could we miscompile such bitcode files? It is not clear what is dropped here.
> 
We are basically ignoring attributes for these. This indeed probably breaks some old bytecode. This was a planned removal, so I think this is fine. However, we may want to have some from form of error triggered rather than just ignoring the old attribute format. I'll do whatever the community think is best here.


https://reviews.llvm.org/D23039





More information about the llvm-commits mailing list