[PATCH] D24545: [LTO] Fix commons handling

[Peter Collingbourne via llvm-commits]

pcc added a comment.

The problem with this solution is that it requires the client to report all instances of the common symbol as prevailing. gold reports a single instance of the symbol as prevailing, and it won't necessarily be the first one. So the gold plugin can't know whether to report any given non-prevailing common symbol as prevailing since it doesn't know whether the eventual prevailing instance will be common or not. That's what the `CommonResolution::Prevailing` bit was tracking in the original gold plugin code. I think we'll need something similar here.


https://reviews.llvm.org/D24545