[PATCH] D24345: [X86][SSE] Improve recognition of i64 sitofp conversions can be performed as i32 (PR29078)

[Andrea Di Biagio via llvm-commits]

andreadb accepted this revision.
andreadb added a comment.

Hi Simon,

the patch lgtm.

I have just one comment (see below).


================
Comment at: test/CodeGen/X86/sse-fsignum.ll:42-45
@@ -41,6 +41,6 @@
 ; AVX1-NEXT:    vpextrq $1, %xmm2, %rax
-; AVX1-NEXT:    vcvtsi2sdq %rax, %xmm3, %xmm3
-; AVX1-NEXT:    vmovq %xmm2, %rax
-; AVX1-NEXT:    vcvtsi2sdq %rax, %xmm4, %xmm2
-; AVX1-NEXT:    vunpcklpd {{.*#+}} xmm2 = xmm2[0],xmm3[0]
+; AVX1-NEXT:    vmovq %xmm2, %rcx
+; AVX1-NEXT:    vmovd %ecx, %xmm2
+; AVX1-NEXT:    vpinsrd $1, %eax, %xmm2, %xmm2
+; AVX1-NEXT:    vcvtdq2pd %xmm2, %xmm2
 ; AVX1-NEXT:    vcmpltpd %xmm0, %xmm1, %xmm0
----------------
Isn't the vmovq+vmovd sequence redundant?


Repository:
  rL LLVM

https://reviews.llvm.org/D24345