[PATCH] D24568: [compiler-rt] Changing function prototype returning unused value

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 09:09:39 PDT 2016


rnk added inline comments.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1891
@@ -1890,3 +1888,3 @@
   // If needed, insert __asan_init before checking for SanitizeAddress attr.
   maybeInsertAsanInitAtFunctionEntry(F);
 
----------------
I think the correct fix is to OR this into a bool like `res` below and return that instead of `false`.


https://reviews.llvm.org/D24568





More information about the llvm-commits mailing list