[PATCH] D24568: [compiler-rt] Changing function prototype returning unused value

[Etienne Bergeron via llvm-commits]

etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
Herald added a subscriber: dberris.

The return value of `maybeInsertAsanInitAtFunctionEntry` is ignored.

https://reviews.llvm.org/D24568

Files:
  lib/Transforms/Instrumentation/AddressSanitizer.cpp

Index: lib/Transforms/Instrumentation/AddressSanitizer.cpp
===================================================================
--- lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -515,7 +515,7 @@
   void instrumentMemIntrinsic(MemIntrinsic *MI);
   Value *memToShadow(Value *Shadow, IRBuilder<> &IRB);
   bool runOnFunction(Function &F) override;
-  bool maybeInsertAsanInitAtFunctionEntry(Function &F);
+  void maybeInsertAsanInitAtFunctionEntry(Function &F);
   void markEscapedLocalAllocas(Function &F);
   bool doInitialization(Module &M) override;
   bool doFinalization(Module &M) override;
@@ -1835,7 +1835,7 @@
   return false;
 }
 
-bool AddressSanitizer::maybeInsertAsanInitAtFunctionEntry(Function &F) {
+void AddressSanitizer::maybeInsertAsanInitAtFunctionEntry(Function &F) {
   // For each NSObject descendant having a +load method, this method is invoked
   // by the ObjC runtime before any of the static constructors is called.
   // Therefore we need to instrument such methods with a call to __asan_init
@@ -1846,9 +1846,7 @@
   if (F.getName().find(" load]") != std::string::npos) {
     IRBuilder<> IRB(&F.front(), F.front().begin());
     IRB.CreateCall(AsanInitFunction, {});
-    return true;
   }
-  return false;
 }
 
 void AddressSanitizer::markEscapedLocalAllocas(Function &F) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24568.71370.patch
Type: text/x-patch
Size: 1370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160914/19804821/attachment.bin>