[PATCH] D23398: [XRay] Synthesize a reference to the xray_instr_map

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 20:47:46 PDT 2016


dberris added a comment.

In https://reviews.llvm.org/D23398#542023, @rnk wrote:

> My thought was that gold and other linkers could look out for use of the `__+section+_start` symbol in the final executable, and use that to figure out when to power down --gc-sections. If it's a data (not code) section and the start and end are used, it seems like a pretty solid bet that the user expects to find that data at runtime.


I expected exactly that behaviour. It was unfortunate to learn that this wasn't the case.

> Anyway, the workaround should be fine for now.


Thanks for having a look!


Repository:
  rL LLVM

https://reviews.llvm.org/D23398





More information about the llvm-commits mailing list