[PATCH] D24533: Fix auto-upgrade of TBAA tags in Bitcode Reader
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 13 20:42:33 PDT 2016
majnemer added a subscriber: majnemer.
================
Comment at: lib/AsmParser/LLParser.cpp:225-226
@@ -224,3 +224,4 @@
- for (unsigned I = 0, E = InstsWithTBAATag.size(); I < E; I++)
- UpgradeInstWithTBAATag(InstsWithTBAATag[I]);
+ for (unsigned I = 0, E = InstsWithTBAATag.size(); I < E; I++) {
+ auto *Inst = InstsWithTBAATag[I];
+ MDNode *MD = Inst->getMetadata(LLVMContext::MD_tbaa);
----------------
Range-based loop?
================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:3752-3753
@@ -3753,3 +3751,4 @@
// are auto-upgraded.
return globalCleanup();
+ return std::error_code();
}
----------------
Return after return?
https://reviews.llvm.org/D24533
More information about the llvm-commits
mailing list