[llvm] r281437 - gold: Simplify. Do not unnecessarily enumerate Obj's symbols.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 19:55:17 PDT 2016


Author: pcc
Date: Tue Sep 13 21:55:16 2016
New Revision: 281437

URL: http://llvm.org/viewvc/llvm-project?rev=281437&view=rev
Log:
gold: Simplify. Do not unnecessarily enumerate Obj's symbols.

Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=281437&r1=281436&r2=281437&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Sep 13 21:55:16 2016
@@ -568,14 +568,10 @@ static void addModule(LTO &Lto, claimed_
     message(LDPL_FATAL, "Could not read bitcode from file : %s",
             toString(ObjOrErr.takeError()).c_str());
 
-  InputFile &Obj = **ObjOrErr;
-
   unsigned SymNum = 0;
   std::vector<SymbolResolution> Resols(F.syms.size());
-  for (LLVM_ATTRIBUTE_UNUSED auto &ObjSym : Obj.symbols()) {
-    ld_plugin_symbol &Sym = F.syms[SymNum];
-    SymbolResolution &R = Resols[SymNum];
-    ++SymNum;
+  for (ld_plugin_symbol &Sym : F.syms) {
+    SymbolResolution &R = Resols[SymNum++];
 
     ld_plugin_symbol_resolution Resolution =
         (ld_plugin_symbol_resolution)Sym.resolution;




More information about the llvm-commits mailing list