[PATCH] D24435: Delete more dead code in SelectionDAG (NFC)

[Vedant Kumar via llvm-commits]

vsk added a comment.

Thanks for your notes.


================
Comment at: include/llvm/CodeGen/SelectionDAG.h:561
@@ -560,3 +560,1 @@
-  SDValue getTargetIndex(int Index, EVT VT, int64_t Offset = 0,
-                         unsigned char TargetFlags = 0);
   // When generating a branch to a BB, we don't in general know enough
----------------
RKSimon wrote:
> This should stay while TargetIndexSDNode exists.
> 
> However, TargetIndexSDNode doesn't appear to be used so maybe start a conversion on llvm-dev about removing it and if successful then propose a separate patch?
It looks like this code has out of tree users (see r250717), so I won't mess with it.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:656
@@ -655,3 +655,1 @@
 
-  unsigned getSDNodeOrder() const { return SDNodeOrder; }
-
----------------
RKSimon wrote:
> Do you know the history behind this and DanglingDebugInfo::getSDNodeOrder()?
No, I don't. Is this something we're better off keeping?


https://reviews.llvm.org/D24435