[PATCH] D24493: Simplify InputFile ownership management.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 10:57:24 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a suggestion for a further simplification if possible.


================
Comment at: ELF/InputFiles.cpp:39
@@ +38,3 @@
+void InputFile::freePool() {
+  // Files are freed in reverse order so that files created
+  // from other files (e.g. object files extracted from archives)
----------------
Do we actually have that requirement?

If not, the Pool could just contain std::unique_ptr and this function could be deleted.


https://reviews.llvm.org/D24493





More information about the llvm-commits mailing list