[PATCH] D24394: [asan] Reify ErrorStringFunctionSizeOverflow

[Filipe Cabecinhas via llvm-commits]

filcab added inline comments.

================
Comment at: lib/asan/asan_errors.h:241
@@ +240,3 @@
+  ErrorStringFunctionSizeOverflow() = default;
+  ErrorStringFunctionSizeOverflow(u32 tid_, BufferedStackTrace *stack_,
+                                  uptr addr, uptr size_)
----------------
vitalybuka wrote:
> Please make consistent arguments order 
> also "tid" could be in ErrorBase
Yeah, I noticed the TID, but wanted to finish with all the errors to make sure we could switch it to Base without wasting too much. We don't need it in ErrorODRViolation, but that's just one error that doesn't need it.
Will double-check arg order. And make more stuff `const`. Most of the Error* members will probably be const.


https://reviews.llvm.org/D24394