What else shall I do to commit my patch to mainline?

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 07:38:05 PDT 2016


Hi Konstantin,

Sometimes patches get lots on llvm-commits. Usually when this happens
people ping after a week or two. Occasionally it takes more than one
ping to get any attention.

Since your patch was submitted in March, it's probably a good idea to
rebase again. Also, in this particular case, you should add some
tests. Are there any in-tree targets that would use such constraints?
If so, you should add tests for at least one of them.

Regards,
Diana

On 13 September 2016 at 11:11, Konstantin Vladimirov via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Hi,
>
> I created some time ago review:
>
> https://reviews.llvm.org/D18036
>
> This is not critical change, but it increases inline assembly
> conformance with GCC (specifically -- multi-letter constraints, like
> "A32").
>
> There have been a silence for a while. Can someone guide me in what to
> do next. I've never committed anything to mainline and feel little
> lost.
>
> ---
> With best regards, Konstantin
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list