[polly] r281234 - Store the size of the outermost dimension in case of newly created arrays that require memory allocation.

[Roman Gareev via llvm-commits]

2016-09-13 14:42 GMT+05:00 Michael Kruse <llvm-commits at meinersbur.de>:
> 2016-09-13 11:07 GMT+02:00 Johannes Doerfert via llvm-commits
> <llvm-commits at lists.llvm.org>:
>>> -  for (int i = 0; i < SharedDims; i++)
>>> -    if (NewSizes[i + ExtraDimsNew] != DimensionSizes[i + ExtraDimsOld])
>>> +
>>> +  for (int i = 0; i < SharedDims; i++) {
>>> +    auto &NewSize = NewSizes[i + ExtraDimsNew];
>>> +    auto &KnownSize = DimensionSizes[i + ExtraDimsOld];
>>> +    if (NewSize && KnownSize && NewSize != KnownSize)
>>>        return false;
>>> +  }
>> Why do you take references of SCEV pointers here? That is not necessary
>> and confusing.
>
> This is ad-hoc code that I suggested to Roman. You are right, the
> references are not necessary. I will correct this.

Sorry, I missed it. Thanks for the comment and the fix.

-- 
                                    Cheers, Roman Gareev.