[PATCH] D24471: [ELF] Set EF_ARM_EABI_VER5 for ARM

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 04:20:24 PDT 2016


mstorsjo updated the summary for this revision.
mstorsjo updated this revision to Diff 71138.
mstorsjo added a comment.

Updated the order of the if statements as requested (alphabetically) and added the requested comment. No tests added yet.


https://reviews.llvm.org/D24471

Files:
  ELF/Writer.cpp

Index: ELF/Writer.cpp
===================================================================
--- ELF/Writer.cpp
+++ ELF/Writer.cpp
@@ -1262,7 +1262,11 @@
   EHdr->e_shnum = OutputSections.size() + 1;
   EHdr->e_shstrndx = Out<ELFT>::ShStrTab->SectionIndex;
 
-  if (Config->EMachine == EM_MIPS)
+  if (Config->EMachine == EM_ARM)
+    // We don't currently use any features incompatible with EF_ARM_EABI_VER5,
+    // but we don't have any firm guarantees of conformance.
+    EHdr->e_flags = EF_ARM_EABI_VER5;
+  else if (Config->EMachine == EM_MIPS)
     EHdr->e_flags = getMipsEFlags<ELFT>();
 
   if (!Config->Relocatable) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24471.71138.patch
Type: text/x-patch
Size: 626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160913/11d211c6/attachment.bin>


More information about the llvm-commits mailing list