[PATCH] D24471: [ELF] Set EF_ARM_EABI_VER5 for ARM

[Ed Maste via llvm-commits]

emaste added a subscriber: emaste.
emaste added a comment.

Can you add a test case?

> Without this flag set, an aarch64 kernel won't try to load the executable


Do you mean this is part of some ABI spec and so any aarch64 kernel should not load the executable, or that this is due to an implementation detail of (presumably) the Linux kernel?


================
Comment at: ELF/Writer.cpp:1265-1268
@@ -1264,4 +1264,6 @@
 
   if (Config->EMachine == EM_MIPS)
     EHdr->e_flags = getMipsEFlags<ELFT>();
+  else if (Config->EMachine == EM_ARM)
+    EHdr->e_flags = EF_ARM_EABI_VER5;
 
----------------
All else being equal I'd keep these in alphabetical order.


https://reviews.llvm.org/D24471