[PATCH] D24483: Convert finite to builtin

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 17:26:53 PDT 2016


danielcdh added a comment.

In https://reviews.llvm.org/D24483#540551, @efriedma wrote:

> "finite()" is a BSD function, not a C standard function, so ALL_LANGUAGES isn't appropriate.


Thanks for the comment. I'm not quite familiar with BSD function. Could you suggest which flag I should use here? C_LANG?

> I can't seem to find documentation for "__finite()"; where is it defined?


It's just that if I include <math.h> and use isfinite(), it will automatically expand to __finite() instead of finite(). But if I call finite() directly, it will expand to finite(). Thus I think I need to handle both __finite and finite. Any suggestions on this?

Thanks,
Dehao


https://reviews.llvm.org/D24483





More information about the llvm-commits mailing list