[PATCH] D24230: [ELF] Linkerscript: Fix handling of empty sections

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 15:05:59 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:175-176
@@ -172,4 +174,4 @@
                              ConstraintKind Kind) {
   if (Kind == ConstraintKind::NoConstraint)
     return true;
   return llvm::all_of(Sections, [=](InputSectionBase<ELFT> *Sec) {
----------------
Now you can remove this.

================
Comment at: ELF/LinkerScript.cpp:327
@@ +326,3 @@
+    Regular->Value = AssignCmd->Expression(VA);
+  }
+}
----------------
Could you answer to this question?


https://reviews.llvm.org/D24230





More information about the llvm-commits mailing list