[PATCH] D24465: [ARM] Support ldr.w in pseudo instruction ldr rd, =immediate

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Two small comments, but otherwise, LGTM.

Feel free to commit with those two changes.

Thanks for the fast turn-around! I'll make sure this gets backported to 3.9.1.

--renato


================
Comment at: test/MC/ARM/ldr-pseudo-wide.s:19
@@ +18,3 @@
+@ CHECK-THUMB2: ldr r0, .Ltmp[[TMP0:[0-9]+]]
+@ CHECK-DARWIN-THUMB2: ldr r0, Ltmp0
+
----------------
shouldn't you also check that the `.Ltmp` symbol has a .word with the right value?

================
Comment at: test/MC/ARM/ldr-pseudo-wide.s:28
@@ +27,3 @@
+@ CHECK-THUMB-NEXT:  ldr.w r0, =0x10002
+@ CHECK-THUMB-NEXT:  ^
+
----------------
you don't need to check on the caret.


https://reviews.llvm.org/D24465