[PATCH] D24458: Using murmurhash2 instead of fnv
Ed Maste via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 12 10:03:28 PDT 2016
emaste added inline comments.
================
Comment at: ELF/Driver.cpp:474
@@ -473,3 +473,3 @@
if (Args.hasArg(OPT_build_id))
- Config->BuildId = BuildIdKind::Fnv1;
+ Config->BuildId = BuildIdKind::Murmur2;
if (auto *Arg = Args.getLastArg(OPT_build_id_eq)) {
----------------
Should we allow the user a way to specify the fast, non-cryptographic hash `--build-id=<something>`? I think so, but I think the implementation detail (which of fnv1/murmur2/xxhash it actually is) is unnecessary.
https://reviews.llvm.org/D24458
More information about the llvm-commits
mailing list