[PATCH] D24237: [ARM] Promote small global constants to constant pools

[James Molloy via llvm-commits]

jmolloy closed this revision.
jmolloy added a comment.

Thanks Oliver, r281213.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:2890
@@ +2889,3 @@
+  //
+  // Only do this if the only users of the constant are in this function (to
+  // avoid duplicating the constant).
----------------
olista01 wrote:
> Would it also be worth doing this for very small constants with multiple uses? If the constant is no larger than a pointer then this won't increase code size, and should help performance by removing a layer of indirection.
Good point, I agree.


Repository:
  rL LLVM

https://reviews.llvm.org/D24237