[PATCH] D24406: [Thumb] Teach ISel how to lower compares of AND bitmasks efficiently

Sjoerd Meijer via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 02:39:57 PDT 2016


SjoerdMeijer added a subscriber: SjoerdMeijer.
SjoerdMeijer added a comment.

Hi James,

Looks good to me. The only question I have is if the regression tests test all the 4 different cases in function SelectCMPZ. Looking at the changed/fixed regression tests, I obviously see a lot of new "lsls", but for example I don't see any (new) LSRri occurences which is case 2) in SelectCMPZ.

Cheers.


Repository:
  rL LLVM

https://reviews.llvm.org/D24406





More information about the llvm-commits mailing list