[PATCH] D24219: [LCG] Redesign the lazy post-order iteration mechanism for the LazyCallGraph to support repeated, stable iterations, even in the face of graph updates.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 11 22:14:28 PDT 2016


chandlerc added a comment.

Working others, but a quick comment below:


================
Comment at: lib/Analysis/LazyCallGraph.cpp:827
@@ +826,3 @@
+    Set.insert(&SourceC);
+    auto IsConnected = [&](RefSCC &RC) {
+      for (SCC &C : RC)
----------------
I mean, I could. Do you think that would be simpler? It seems like it would be strictly more complicated than this, and still O(edges), so it didn't seem like it was worth pursuing. But I'm happy to try it out if you think it'd be an improvement.


https://reviews.llvm.org/D24219





More information about the llvm-commits mailing list