[PATCH] D22403: FileCheck Enhancement - pattern templates.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 10 12:00:33 PDT 2016


vsk added a comment.

In https://reviews.llvm.org/D22403#539395, @eklepilkina wrote:

> Are quotes necessary for parameters? Everything is string in FileCheck.


Yes, the quotes are necessary. Without them the grammar is ambiguous. Consider the string '@foo(a, b)'. Is there just one argument to foo (the string "a, b"), or are there two arguments ("a" and "b")?

> Using patterns and variables was in old grammer. I thought that we only change syntax, so I added this feature too.

>  Ok, I'll remove this from this patch. But then I want to add using patterns and variables in definitions later. On my opinion these features are quite useful.


Sounds great :).


https://reviews.llvm.org/D22403





More information about the llvm-commits mailing list