[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

Victor Leschuk via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 20:26:15 PDT 2016


vleschuk added a comment.

In https://reviews.llvm.org/D24425#539081, @probinson wrote:

> DW_FORM_data8 seems wasteful.  I'd rather see DW_FORM_udata.


Agreed. I also had a thought that data8 is too large for that. I just (for some reason) was sure that DWARF document explicitly stated that value should be 64 bit. Rechecked now: there is no such info in that doc, I was mistaken. Will fix.


https://reviews.llvm.org/D24425





More information about the llvm-commits mailing list