[PATCH] D24436: Fix misleading comment for getOrEnforceKnownAlignment

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 18:15:21 PDT 2016


jlebar added inline comments.

================
Comment at: include/llvm/Transforms/Utils/Local.h:165
@@ +164,3 @@
+/// If \p PrefAlign is more than the alignment of the ultimate object the
+/// specified pointer is derived from that we control, modify the object's
+/// alignment to PrefAlign. This isn't often possible though. If alignment is
----------------
This prep phrase is unwieldy.  Can we rephrase?  (I'd give a suggestion but I'm not actually sure what it means.)

================
Comment at: include/llvm/Transforms/Utils/Local.h:170
@@ +169,3 @@
+///
+/// If the alignment cannot be modified, return the determined alignment value.
+///
----------------
What do we return if the alignment can be modified?


https://reviews.llvm.org/D24436





More information about the llvm-commits mailing list