[PATCH] D24432: Get rid of Data and RawData in CVRecord

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 15:20:37 PDT 2016


zturner created this revision.
zturner added a reviewer: rnk.
zturner added a subscriber: llvm-commits.

To make this work, we had to make restrict the usage of `CVRecord` to mean "record with length-specified prefix".  This means `CVRecord` can no longer be used for field list members since they don't describe their own length and don't contain a prefix.  So a new type is introduced called `CVMemberTypeRecord`, and then all the associated fallout is dealt with.  Mostly this means changing all visitors to use separate methods for visiting `CVRecords` vs `CVMemberTypeRecords`, there's just a lot of it.

https://reviews.llvm.org/D24432

Files:
  include/llvm/DebugInfo/CodeView/CVRecord.h
  include/llvm/DebugInfo/CodeView/CVSymbolVisitor.h
  include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
  include/llvm/DebugInfo/CodeView/TypeDeserializer.h
  include/llvm/DebugInfo/CodeView/TypeDumper.h
  include/llvm/DebugInfo/CodeView/TypeRecord.h
  include/llvm/DebugInfo/CodeView/TypeSerializationVisitor.h
  include/llvm/DebugInfo/CodeView/TypeVisitorCallbackPipeline.h
  include/llvm/DebugInfo/CodeView/TypeVisitorCallbacks.h
  include/llvm/DebugInfo/PDB/Raw/TpiStreamBuilder.h
  lib/DebugInfo/CodeView/CVTypeVisitor.cpp
  lib/DebugInfo/CodeView/TypeDumper.cpp
  lib/DebugInfo/CodeView/TypeStreamMerger.cpp
  lib/DebugInfo/PDB/Raw/TpiRecordHashVisitor.cpp
  tools/llvm-pdbdump/CodeViewYaml.cpp
  tools/llvm-pdbdump/CodeViewYaml.h
  tools/llvm-pdbdump/LLVMOutputStyle.cpp
  tools/llvm-pdbdump/PdbYaml.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24432.70917.patch
Type: text/x-patch
Size: 39768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160909/b6b19505/attachment.bin>


More information about the llvm-commits mailing list