[PATCH] D20147: [WIP] DebugInfo: New metadata representation for global variables.

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D20147#539056, @pcc wrote:

> My recollection is that the lazy loading issues discussed are not a blocker, as they do not represent a perf regression (DIGlobalVariable metadata is already being loaded eagerly). Changing the bitcode representation for global variables to allow for lazy loading can be done separately.
>
> If there are no other issues this patch most likely just needs a sign off (and a refresh given its age).


I may misunderstand what this will change, it seems to me that this is a regression in lazy loading. Currently lazy loading bitcode does *not* load global metadata, while after this change it will load all what is reachable from the metadata attached to a global.
It would matter when the linker lazy load to perform symbol resolution for instance, which is a blocker I think.

On the other side, if something like https://reviews.llvm.org/D23132 lands, that would probably unblock this as we would have another path than lazy-loading bitcode.


https://reviews.llvm.org/D20147