[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 11:41:22 PDT 2016


vitalybuka added inline comments.

================
Comment at: lib/asan/asan_descriptions.h:197
@@ +196,3 @@
+  AddressDescription(uptr addr, uptr length,
+                     bool shouldLockThreadRegistry = true) {
+    if (GetShadowAddressInformation(addr, &data.shadow)) {
----------------
And I'd prefer for now remove shouldLockThreadRegistry argument and do ThreadRegistryLock inside of GetStackAddressInformation uconditionally


https://reviews.llvm.org/D24131





More information about the llvm-commits mailing list