[PATCH] D21723: [RFC] Enhance synchscope representation

Neil Henning via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 02:20:56 PDT 2016


sheredom added a subscriber: sheredom.
sheredom added a comment.

This is something we (Codeplay) would like to see upstream, it is a much cleaner solution than the metadata workarounds everyone (including us) have been using to fix this.

I minorly dislike synchscope as the term for it - syncscope reads better to me (I read the former as 'Singe Scope', the latter as 'Sink Scope').


================
Comment at: include/llvm/IR/Instructions.h:40
@@ -39,2 +39,3 @@
 
-enum SynchronizationScope {
+/// Prededined synchronization scopes.
+enum SynchronizationScope : unsigned {
----------------
Prededined -> Predefined


https://reviews.llvm.org/D21723





More information about the llvm-commits mailing list