[PATCH] D24324: AMDGPU: Fix selection failure with dead AssertZext

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 01:37:19 PDT 2016


nhaehnle added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1554-1555
@@ -1553,1 +1553,4 @@
+
+      if (EffectiveFI->use_empty())
+        CurDAG->RemoveDeadNode(EffectiveFI.getNode());
     }
----------------
I think this should be outside the loop that iterates over It.

Also, is it a problem if all uses of the FI were removed for the current block, but there are uses in other blocks? Perhaps this check should only apply in the case where FI != EffectiveFI?


https://reviews.llvm.org/D24324





More information about the llvm-commits mailing list