[PATCH] D24060: [lld][ELF] Add support for -b binary

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 17:51:19 PDT 2016


Bigcheese added inline comments.

================
Comment at: ELF/InputFiles.h:310
@@ +309,3 @@
+private:
+  std::unique_ptr<char[]> ELFData;
+};
----------------
ruiu wrote:
> Is this equivalent to `std::unique_ptr<char *>`? If so, please write that way.
> 
> Can you use uint8_t instead of char?
It needs to be [] so that delete[] is called instead of delete. But I'm actually going to change it to std::vector.

I can change it to uint8_t.


https://reviews.llvm.org/D24060





More information about the llvm-commits mailing list