[PATCH] D23172: Treat aliased registers as live in if-conversion

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 16:49:03 PDT 2016


qcolombet added a comment.

Hi Krzysztof,

Thanks for your patience, I missed the patch earlier.

I don't like the idea of the if-converter growing the live-in set for no apparent reason. In my opinion, we end up in this situation because other passes did something wrong, like in that case the Copy-To-Combine pass if I understand correctly.

To give a bit more concret on why I don't like it, Matthias recently removed a similar fix in BranchFolding IIRC, that in the end was kidding bugs somewhere else.

Cheers,
-Quentin


Repository:
  rL LLVM

https://reviews.llvm.org/D23172





More information about the llvm-commits mailing list